Change 23436 - Needs Code-Review
WIP: Automatically download TBB binaries when enabled This patch import CMake modules from the tbb project to automatically download binaries.
Author May 16, 2018 10:13 AM
Committer May 16, 2018 10:17 AM
Commit
fa109b8b37ff6d11356c7daa84f10962d303cdef
Parent(s)
aa57caf04732f8c0b56f575b65c532e107720e49
Change-Id
Ifa109b8b37ff6d11356c7daa84f10962d303cdef
Owner
Uploader
Reviewers
Kitware Build Robot
Dzenan Zukic Francois Budin Matt McCormick
Project ITK
Branch master
Topic
Strategy Always Merge
Updated 7 months ago

Build-Status
Code-Review
Verified
-1 Kitware Build Robot
 
 
Files
History
Bradley Lowekamp
May 16, 2018

Uploaded patch set 1.

Bradley Lowekamp
May 16, 2018

Patch Set 1:

This was the quickest way for me to get TBB working.

They have a lot of CMake modules: https://github.com/01org/tbb/tree/tbb_2018/cmake

Some that should even support the CMake configuration interface with a "system" TBB without a CMake config.

Kitware Build Robot
May 16, 2018
Dzenan Zukic
May 16, 2018

Patch Set 1:

This does not modify the "system" variable mechanism. The behavior before this patch was to always use system TBB. The patch changes is to always download TBB. Downloading is fine but we should have the option to use the system one.

I did not examine the code closely. Does this download binaries only for the current compiler or all the provided binaries?

Bradley Lowekamp
May 16, 2018

Patch Set 1:

This was just a hack to get the TBB working for me. The linux binary support several compilers and include Debug/Release versions all specified in the CMake configuration file.

TBB including a CMake configuration file is a new feature. Many "system" i.e. RH7 TBB packages don't include the CMake configuration file that find_package(TBB) is looking for. I believe in the TBB source repo the have additional CMake files to interface to "legacy system" TBBs missing CMake files.

Dzenan Zukic
May 16, 2018

Patch Set 1:

You are right. TBB added a proper CMake support about half a year ago.

Powered by Gerrit Static Archive (2.12-1-g6f7dc21) |