Change 8884 - Abandoned
BUG: PNGImageIO no longer uses invalid units in sCAL chunk Change-Id: Iae27ef5f95c669a5a438313a15b0af7ad3514996
Author Dec 12, 2012 3:39 AM
Committer Apr 4, 2013 7:24 PM
Commit
bb0a9fea2f85716efe3bc25ed34877b45cb8e3e8
Parent(s)
bf9823770586a67420848df3f224159c0da897ef
Change-Id
Iae27ef5f95c669a5a438313a15b0af7ad3514996
Owner
Uploader
Matt McCormick
Reviewers
Bill Lorensen
Bradley Lowekamp Hans J. Johnson Matt McCormick
Project ITK
Branch master
Topic
Updated 4 years, 10 months ago

Code-Review
-2 Bill Lorensen
Verified
Files
History
Hans J. Johnson
Mar 24, 2013

Uploaded patch set 2.

Kitware Robot
Mar 24, 2013
Matt McCormick
Apr 2, 2013

Patch Set 2: Fails

Tests are failing

Matt McCormick
Apr 4, 2013

Patch Set 2:

Next patch set allows some more tests to pass, but I do not know if it is the write thing to do. We should try to get backwards-compatible behavior if possible.

Matt McCormick
Apr 4, 2013

Uploaded patch set 3.

Kitware Robot
Apr 4, 2013
Bill Lorensen
Apr 7, 2013

Patch Set 3: Do not submit

Must maintain backward compatibility

Bill Lorensen
Apr 7, 2013

Patch Set 3:

As I mentioned in an earlier e-,ail, pHYs measures pixel size/aspect ration. sCAL is the proper parameter to change, but as you pointed out, ITK is not writing out a correct sCAL unit type. Since ITK does not have a concept of unit, I think we just need to repair the output image to specify a valid unit type, which probably should be meters rather than radians.

Hans J. Johnson
Feb 20, 2014

Patch Set 3: Abandoned

This is more than a year old with out any progress on a resoution. If something will be done to address the raised concerns, then re-open the patch.

Powered by Gerrit Static Archive (2.12-1-g6f7dc21) |